Skip to content

#285 issue: mention all suported external libraries in /feature page - #400

Closed
imspidey6989 wants to merge 7 commits into
mixxxdj:websitefrom
imspidey6989:bhagyabajoria/issue285
Closed

#285 issue: mention all suported external libraries in /feature page#400
imspidey6989 wants to merge 7 commits into
mixxxdj:websitefrom
imspidey6989:bhagyabajoria/issue285

Conversation

@imspidey6989

@imspidey6989 imspidey6989 commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

UI/UX was enhanced for greater clarity and user experience, and the website was updated to reflect the increased support for DJ libraries. features integration with Rhythmbox, Banshee, Rekordbox, iTunes, Traktor, and Serato.

Preview

@ronso0 ronso0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Comment thread theme/templates/pages/features.html Outdated
<img class="responsive drop-shadow" src="{{ SITEURL }}/theme/images/2.0/feature-library.png">
<h6 class="docs-header">{% trans %}iTunes and Traktor Library Integration{% endtrans %}</h6>
<p>{% trans %}Drop fresh tracks from your iTunes or Traktor library right into your mix.{% endtrans %}</p>
<h6 class="docs-header">{% trans %}Universal DJ Library Integration{% endtrans %}</h6>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h6 class="docs-header">{% trans %}Universal DJ Library Integration{% endtrans %}</h6>
<h6 class="docs-header">{% trans %}External DJ Library Integration{% endtrans %}</h6>

because Mixxx doesn't support each and every library format out there.

@imspidey6989

Copy link
Copy Markdown
Contributor Author

Here is the new update

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 , do you like the update, or would you prefer to give me feedback so I can improve it?

@ronso0

ronso0 commented Jul 29, 2025

Copy link
Copy Markdown
Member

Connect and sync tracks seamlessly across iTunes, ...

Hmm, Mixxx can read all these libraries, but I'm not sure about sync (write back to them). I never used any external libraries, or at least it's been a while.

Oh, it's in the settings: they are write-protected
image

Comment thread theme/templates/pages/features.html Outdated
<h6 class="docs-header">{% trans %}iTunes and Traktor Library Integration{% endtrans %}</h6>
<p>{% trans %}Drop fresh tracks from your iTunes or Traktor library right into your mix.{% endtrans %}</p>
<h6 class="docs-header">{% trans %}External DJ Library Integration{% endtrans %}</h6>
<p>{% trans %}Connect and sync tracks seamlessly across iTunes, Traktor, Banshee, Rekordbox, Rhythmbox, Serato, and more — drop fresh tracks from any library right into your mix.{% endtrans %}</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Suggested change
<p>{% trans %}Connect and sync tracks seamlessly across iTunes, Traktor, Banshee, Rekordbox, Rhythmbox, Serato, and moredrop fresh tracks from any library right into your mix.{% endtrans %}</p>
<p>{% trans %}Mixxx can read the libraries of iTunes, Traktor, Banshee, Rekordbox, Rhythmbox and Seratojust load them and drop fresh tracks right into your mix.{% endtrans %}</p>

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 , check this one out is it good now

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 , now I think Everything is good going. If not please give me the feedback
Thank You

Comment thread theme/templates/pages/features.html Outdated
@imspidey6989

imspidey6989 commented Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

@ronso0 I think now it is all good, sorry for the delay

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 is anything wrong, If any just tell me the feedback I will work on it.

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 waiting for the reply. Please give the feedback

@Eve00000

Eve00000 commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Please @bhagyabajoria , please be a little patient, we are all volunteers and we (try to) have a life outside of Mixxx.
@ronso0 will answer you as soon as he has time to devote to Mixxx.

@imspidey6989

Copy link
Copy Markdown
Contributor Author

Please @bhagyabajoria , please be a little patient, we are all volunteers and we (try to) have a life outside of Mixxx. @ronso0 will answer you as soon as he has time to devote to Mixxx.

Thanks for the response, I am not in any hurry, I just Thought that @ronso0 is bit angry on me due to late replay so it is seem to be impatient. Sorry for the inconvenience @Eve00000 @ronso0 .

@ronso0

ronso0 commented Aug 4, 2025

Copy link
Copy Markdown
Member

No one is angry, and there's no need to rush here : )
It's just that this PR is rather low prio, compared to bugfixes, the GSoC projects.. and often: personal projects ; )

Will take a look soon, but I'd appreciate other @mixxxdj/developers take a look, especially the native english speakers.

@ronso0

ronso0 commented Aug 4, 2025

Copy link
Copy Markdown
Member

In case I forget, feel free to ping me in a week or so.

@imspidey6989

Copy link
Copy Markdown
Contributor Author

Hey @ronso0 , hope you are fine. Just a general reminder to review the commit if there is anything to do feel free to give me feedback.

Thank you

@imspidey6989

Copy link
Copy Markdown
Contributor Author

Hey @ronso0, do you like the update. if not, please tell me the feedback
Thankyou

@imspidey6989
imspidey6989 requested a review from ronso0 August 10, 2025 05:48
@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 , please respond my message. it's great if you just see and if you need anything please tell me.
thank you

@Swiftb0y Swiftb0y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The longer text shifts the layout around in an unpleasant fashion.
Consider reording the <div>s/<p>s so the empty space is on the bottom right
Image

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y then what should i do should i make the text small or should i change the text

@imspidey6989

imspidey6989 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

if make the line short it does make sense as it don't have enough it which a user want.
an in previous version the text already make a significant space in between the text you can see below
Screenshot 2025-08-14 210726
one thing i can do is elaborate this section attached below as it then make the gap shorter
image
Or if there is any image available i can insert there to fill the gap.
what do you think @Swiftb0y . Please give the feedback.
Thank You

@imspidey6989
imspidey6989 requested a review from Swiftb0y August 14, 2025 15:50
@Swiftb0y

Copy link
Copy Markdown
Member

Adding an image is a good idea (though overkill), I'd say just move the "external DJ integration" paragraph from the top of the right column to the bottom of the left one?

@imspidey6989

Copy link
Copy Markdown
Contributor Author
image like this @Swiftb0y @ronso0

@imspidey6989

imspidey6989 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

can you just provide me the image @Swiftb0y @ronso0

@imspidey6989

imspidey6989 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author
image @Swiftb0y @ronso0 should i commit this

@ronso0

ronso0 commented Aug 14, 2025

Copy link
Copy Markdown
Member

Let's not add an extra image here, just try to move the updated paragraph/div to the left column.

@Swiftb0y

Copy link
Copy Markdown
Member

The screenshot that is already there is meaningless anyways. I think we should replace it with a screenshot of the library sidebar with the logos. Wdyt of something like this (imagine it was higher res and had all libraries listed):
image

That would fill out that space pretty nicely

@imspidey6989

Copy link
Copy Markdown
Contributor Author
image @ronso0 @Swiftb0y is it good

@Swiftb0y

Copy link
Copy Markdown
Member

Fixed it for you ;) imspidey6989#1

move musicbrainz paragraph to left column
imspidey6989 added a commit to imspidey6989/website that referenced this pull request Aug 15, 2025
@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y @ronso0 i think it is good

@Swiftb0y

Copy link
Copy Markdown
Member

please drop the last commit that reformats the entire file.

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y the commit title finall version

@imspidey6989
imspidey6989 force-pushed the bhagyabajoria/issue285 branch from a136012 to ba84890 Compare August 15, 2025 10:47
@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y @ronso0 is it good

@Swiftb0y

Swiftb0y commented Aug 15, 2025

Copy link
Copy Markdown
Member

Great. Now squash the intermediate commits too. No reason to have 7 commits for a single logical change

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y removing older commit is hard as i have to remove all the commit first and then upload it is bad moving i guess

@Swiftb0y

Copy link
Copy Markdown
Member

Not really, look into "interactive rebasing". https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

@imspidey6989

Copy link
Copy Markdown
Contributor Author

actually i don't know how to perform it so please just merge as i don't that bad so i will become better in future @Swiftb0y

@Swiftb0y

Copy link
Copy Markdown
Member

Did it manually for you. Thanks for the PR ;)

@Swiftb0y Swiftb0y closed this Aug 15, 2025
@imspidey6989

Copy link
Copy Markdown
Contributor Author

@Swiftb0y no merge why?

@ronso0

ronso0 commented Aug 15, 2025

Copy link
Copy Markdown
Member

Because @Swiftb0y merged the commits directly https://github.com/mixxxdj/website/commits/website/
e26b3e6
aadd13c

@Swiftb0y

Copy link
Copy Markdown
Member

Yup, also tried to do it in such a way that you're still credited
image

@imspidey6989

Copy link
Copy Markdown
Contributor Author

@ronso0 @Swiftb0y @Eve00000 thanks for the support it a great to learn from you all.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants